From 6c4eeb773e1fa39ab63045c23548a14949b50446 Mon Sep 17 00:00:00 2001
From: Andreas Romeyke <art1@andreas-romeyke.de>
Date: Mon, 25 Oct 2021 12:03:04 +0200
Subject: [PATCH] - __buildBag() uses signatures now - simplifed title-check

---
 lib/SLUB/LZA/SIPBuilderBagIt.pm | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/lib/SLUB/LZA/SIPBuilderBagIt.pm b/lib/SLUB/LZA/SIPBuilderBagIt.pm
index a382b65..62f4e3d 100644
--- a/lib/SLUB/LZA/SIPBuilderBagIt.pm
+++ b/lib/SLUB/LZA/SIPBuilderBagIt.pm
@@ -334,26 +334,16 @@ sub create_slub_bagit($bagPath,$refAddBagInfo){
     return 1;
 }
 
-sub __buildBag {
-    my $ppn = shift;
-    my $noppn = shift;
-    my $rightsFilePath = shift;
-    my $aRefAddMetaFile = shift;
-    my $refAddBagInfo = shift;
-    my $bagPath = shift;
-    my $metaPath = shift;
-
+sub __buildBag ($ppn, $noppn, $rightsFilePath, $aRefAddMetaFile, $refAddBagInfo, $bagPath, $metaPath){
     # create meta dir
     SLUB::LZA::SIPBuilderBagIt::createDir($metaPath);
     my @addMetaFile = @{ $aRefAddMetaFile };
     my @addBagInfo = @{ $refAddBagInfo };
     my $marc21;
-
     # get descriptive metadata from catalog
     if ($ppn) {
         $marc21 = get_marc21_from_catalogue($ppn);
     }
-
     # copy not payload files to meta
     SLUB::LZA::SIPBuilderBagIt::copyFilesToMeta($ppn, $metaPath, $rightsFilePath, \@addMetaFile, $marc21);
     # add metadata for bag-info.txt
@@ -405,7 +395,7 @@ sub checkForTitle($key_hash_list_aref){
         push @keys, keys %{$hash};
     }
     # check for title
-    if (none { $_ =~ m/^[Tt][Ii][Tt][Ll][Ee]/ } @keys) {
+    if (none { lc($_) =~ m/^title/ } @keys) {
         print_scalar_data("", "WARNING: No Title given. Please consider adding a human-readable title with '--add_key_value=Title:YOUR-TITLE'", "", "yellow");
         return 0;
     }
-- 
GitLab