From 3af1d3d0d4c8f4d95c5aef637b2f3ffe8d260c0c Mon Sep 17 00:00:00 2001
From: Jens Steidl <Jens.Steidl@slub-dresden.de>
Date: Tue, 7 Feb 2023 14:20:56 +0100
Subject: [PATCH] fix: repairs autocomplete based on aliases, adds
 .bash-profile files

---
 tasks/configure_processing_user.yml | 28 ++++++++++++++++++++++++++++
 tasks/install_subapp.yml            | 12 ------------
 2 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/tasks/configure_processing_user.yml b/tasks/configure_processing_user.yml
index 9a5b7a6..670259d 100644
--- a/tasks/configure_processing_user.yml
+++ b/tasks/configure_processing_user.yml
@@ -28,6 +28,20 @@
     block: |
       cd ~
 
+# Bash-Completion funktioniert ab 2020.2 anders, s. Abschnitt AUTOCOMPLETION in perldoc bin/subapp_rosetta.pl und bin/disapp_rosetta.pl
+- name: configure .bash-profile for DisApp user
+  ansible.builtin.blockinfile:
+    path: "/home/{{ vault_disapp_user }}/.bash-profile"
+    backup: "no"
+    create: "yes"
+    owner: "{{ vault_disapp_user }}"
+    group: "{{ vault_disapp_group }}"
+    mode: "0644"
+    marker: "# {mark} ANSIBLE MANAGED BLOCK - DisApp-specific"
+    state: present
+    block: |
+      complete -C disapp disapp
+
 - name: configure .bashrc for SubApp user
   ansible.builtin.blockinfile:
     path: "/home/{{ vault_subapp_user }}/.bashrc"
@@ -66,6 +80,20 @@
 
       cd ~
 
+# Bash-Completion funktioniert ab 2020.2 anders, s. Abschnitt AUTOCOMPLETION in perldoc bin/subapp_rosetta.pl und bin/disapp_rosetta.pl
+- name: configure .bash-profile for SubApp user
+  ansible.builtin.blockinfile:
+    path: "/home/{{ vault_subapp_user }}/.bash-profile"
+    backup: "no"
+    create: "yes"
+    owner: "{{ vault_subapp_user }}"
+    group: "{{ vault_subapp_group }}"
+    mode: "0644"
+    marker: "# {mark} ANSIBLE MANAGED BLOCK - SubApp-specific"
+    state: present
+    block: |
+      complete -C subapp subapp
+
 - name: Add aliases for DisApp user
   ansible.builtin.blockinfile:
     path: "/home/{{ vault_disapp_user }}/.bash_aliases"
diff --git a/tasks/install_subapp.yml b/tasks/install_subapp.yml
index 2e0d340..171038b 100644
--- a/tasks/install_subapp.yml
+++ b/tasks/install_subapp.yml
@@ -220,18 +220,6 @@
       owner: "{{ vault_subapp_user }}"
       group: "{{ vault_subapp_group }}"
 
-# Bash-Completion funktioniert ab 2020.2 anders, s. Abschnitt AUTOCOMPLETION in perldoc bin/subapp_rosetta.pl und bin/disapp_rosetta.pl
-# https://ansible-lint.readthedocs.io/en/latest/usage/#false-positives-skipping-rules
-- name: Bash-Completion aktivieren    # noqa command-instead-of-shell
-  ansible.builtin.shell:
-    chdir: "/usr/local/bin/"
-    cmd: "{{ item }}"
-    executable: "/usr/bin/bash"       # Yup, this REALLY needs a Bash, so we HAVE to use ansible.builtin.shell, so don't show linter errors
-  loop:
-    - "complete -C subapp_rosetta.pl subapp_rosetta.pl"
-    - "complete -C disapp_rosetta.pl disapp_rosetta.pl"
-  changed_when: false
-
 - name: alte Bash-Completion entfernen
   ansible.builtin.file:
     path: "/home/{{ vault_subapp_user }}/.bash_completion"
-- 
GitLab