From 38b664a0d7cf14a0edf501f61b8877cd989e7c86 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Sachse?= <joerg.sachse@slub-dresden.de>
Date: Tue, 23 May 2023 09:57:28 +0200
Subject: [PATCH] style: satisfy linter
---
.ansible-lint | 2 ++
handlers/main.yml | 2 +-
meta/main.yml | 2 ++
tasks/configure_ssh_keys.yml | 2 +-
tasks/install_packages.yml | 2 +-
5 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/.ansible-lint b/.ansible-lint
index f18a647..491cf72 100644
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -37,6 +37,8 @@ use_default_rules: true
skip_list:
- skip_this_tag
- git-latest
+ - name[casing]
+ - package-latest
# Any rule that has the 'opt-in' tag will not be loaded unless its 'id' is
# mentioned in the enable_list:
diff --git a/handlers/main.yml b/handlers/main.yml
index e272215..4d68533 100644
--- a/handlers/main.yml
+++ b/handlers/main.yml
@@ -5,6 +5,7 @@
state: restarted
- name: save iptables rules (Debian)
+ when: ansible_os_family == "Debian"
block:
- name: Ordner für iptables-Config erstellen
ansible.builtin.file:
@@ -23,4 +24,3 @@
ansible.builtin.command: 'netfilter-persistent save'
listen: "save iptables rules"
changed_when: false
- when: ansible_os_family == "Debian"
diff --git a/meta/main.yml b/meta/main.yml
index f41d21c..940c93f 100644
--- a/meta/main.yml
+++ b/meta/main.yml
@@ -1,5 +1,7 @@
---
galaxy_info:
+ role_name: "ansible_lza_sanitytest"
+ namespace: "slub"
author: Jörg Sachse
company: SLUB Dresden
description: role to install a post-upgrade sanity testing server for the SLUBarchiv digital preservation repository
diff --git a/tasks/configure_ssh_keys.yml b/tasks/configure_ssh_keys.yml
index f094f5e..46e8492 100644
--- a/tasks/configure_ssh_keys.yml
+++ b/tasks/configure_ssh_keys.yml
@@ -1,6 +1,6 @@
---
- name: deploy SSH key for management user
- ansible.builtin.authorized_key:
+ ansible.posix.authorized_key:
user: "{{ item.user }}"
state: "{{ item.state | default('present') }}"
key: "{{ item.ssh_key }}"
diff --git a/tasks/install_packages.yml b/tasks/install_packages.yml
index d990291..d7cedb3 100644
--- a/tasks/install_packages.yml
+++ b/tasks/install_packages.yml
@@ -35,7 +35,7 @@
]
- name: install Perl packages from CPAN
- ansible.builtin.cpanm:
+ community.general.cpanm:
name: "{{ item }}"
loop:
# these are part of the "perl-base" Debian 10 package, so we get them for free:
--
GitLab