From d1ac3dfc1ac2d75a643c035db638139e343bdb3f Mon Sep 17 00:00:00 2001
From: Andreas Romeyke <art1@andreas-romeyke.de>
Date: Wed, 23 Feb 2022 16:51:05 +0100
Subject: [PATCH] - refactoring and cleanup - add argument checks

---
 test.sh | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/test.sh b/test.sh
index 1bb4f05..d85103c 100644
--- a/test.sh
+++ b/test.sh
@@ -1,10 +1,16 @@
 #!/bin/bash
-EXL=/exlibris/dps/d4_1/system.dir/dps-sdk-7.1.0/
-java -cp \
-"${EXL}/lib/dps-sdk-7.1.0.jar:${EXL}/dps-sdk-projects/dps-sdk-deposit/lib/log4j-1.2.14.jar:\
-${EXL}/dps-sdk-projects/dps-sdk-deposit/lib/commons-codec-1.10.jar:\
-${EXL}/dps-sdk-projects/dps-sdk-deposit/lib/xmlbeans-2.3.0.jar:\
-/usr/share/java/commons-lang.jar:\
-./SLUBTechnicalMetadataExtractorCheckItTiffPlugin.jar:./SLUBTechnicalMetadataExtractorCheckItTiffPlugin.jar" \
-org.slub.rosetta.dps.repository.plugin.SLUBTechnicalMetadataExtractorCheckItTiffPlugin \
-"$1"
+
+# check arguments
+if [ "$#" -lt 1 ]; then echo "error: no media file given"; exit 1; fi
+if [ ! -f "$1" ]; then echo "error: media file '$1' does not exist"; exit 1; fi
+
+# set variables
+MEDIA_FILE="$1";
+ROSETTAVERSION="7.1.0"
+ROSETTA_SDK_DIR="/exlibris/dps/d4_1/system.dir/dps-sdk-${ROSETTAVERSION}"
+ROSETTA_SDK_JAR="${ROSETTA_SDK_DIR}/lib/dps-sdk-${ROSETTAVERSION}.jar:${ROSETTA_SDK_DIR}/dps-sdk-projects/dps-sdk-deposit/lib/log4j-1.2.14.jar"
+PLUGIN_JAR="./SLUBTechnicalMetadataExtractorCheckItTiffPlugin.jar"
+PLUGIN_NAME="org.slub.rosetta.dps.repository.plugin.SLUBTechnicalMetadataExtractorCheckItTiffPlugin"
+
+# run plugin
+java -cp "${ROSETTA_SDK_JAR}:${PLUGIN_JAR}" "${PLUGIN_NAME}" "${MEDIA_FILE}"
-- 
GitLab