From 3c67e4057e15029331f42445ea22eae9905690fd Mon Sep 17 00:00:00 2001
From: Jens Steidl <Jens.Steidl@slub-dresden.de>
Date: Mon, 14 Feb 2022 18:15:07 +0100
Subject: [PATCH] - refactor: use signatures
---
.../add_dnx_mappings/add_dnx_mappings.pl | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/deploy_mediaconch/add_dnx_mappings/add_dnx_mappings.pl b/deploy_mediaconch/add_dnx_mappings/add_dnx_mappings.pl
index cc65d34..469e76f 100644
--- a/deploy_mediaconch/add_dnx_mappings/add_dnx_mappings.pl
+++ b/deploy_mediaconch/add_dnx_mappings/add_dnx_mappings.pl
@@ -14,7 +14,8 @@
use strict;
use warnings;
use utf8;
-use feature qw(say);
+use feature qw(say signatures);
+no warnings qw(experimental::signatures);
use Selenium::Remote::Driver;
use Selenium::Chrome;
use Term::ANSIColor; # colored print
@@ -195,9 +196,7 @@ sub change_to_local_format_library {
$driver->pause();
}
-sub add_dnx_property($$) {
- my $dnx_property = shift;
- my $dnx_description = shift;
+sub add_dnx_property ($dnx_property, $dnx_description) {
my $dow = localtime;
$driver->get("$protocol://$host:${ui_port}/mng/action/pageAction.page_xml.page_sig_prop_list.xml.do?pageViewMode=Edit&pageBean.currentUserMode=GLOBAL&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryGLOBAL.mngLibraryHeader.SigProps.InnerMenu&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryGLOBAL.mngLibraryHeader.SigProps.InnerMenu&backUrl=");
$driver->pause();
@@ -209,8 +208,7 @@ sub add_dnx_property($$) {
$driver->find_element("SaveSigPropGenDetails", "name")->click;
}
-sub join_dnx_property_to_classification_group($) {
- my $dnx_property = shift;
+sub join_dnx_property_to_classification_group ($dnx_property) {
say "try to join dnx property";
$driver->get("$protocol://$host:${ui_port}/mng/action/pageAction.page_xml.page_classification_list.xml.do?pageViewMode=Edit&pageBean.currentUserMode=GLOBAL&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryGLOBAL.mngLibraryHeader.Classifications.InnerMenu&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryGLOBAL.mngLibraryHeader.Classifications.InnerMenu&backUrl=");
$driver->pause();
@@ -227,9 +225,7 @@ sub join_dnx_property_to_classification_group($) {
$driver->pause();
}
-sub extractors_add_mapping($$) {
- my $dnx_property = shift;
- my $mediainfo_property = shift;
+sub extractors_add_mapping ($dnx_property, $mediainfo_property) {
say "try to add extractor mapping";
$driver->get("$protocol://$host:${ui_port}//mng/action/pageAction.page_xml.page_extractors_list.xml.do?pageBean.deploymentMode=BUNDLED&pageViewMode=Edit&pageBean.currentUserMode=LOCAL&RenewBean=true&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryLOCAL.mngLibraryHeader.Extractors.InnerMenu&menuKey=com.exlibris.dps.wrk.general.menu.Preservation.AdvancedPreservationActivities.mngLibraryLOCAL.mngLibraryHeader.Extractors.InnerMenu&backUrl=");
$driver->pause();
--
GitLab