From bc1460d548f5ee650215c7d9902022a5fdb5b8ff Mon Sep 17 00:00:00 2001
From: Jens Steidl <Jens.Steidl@slub-dresden.de>
Date: Wed, 17 Aug 2022 10:45:14 +0200
Subject: [PATCH] - fixed NPE (Cannot invoke "String.length()" because
"<local5>" is null) in String comparison to tackle underlying issue
---
.../repository/plugin/storage/nfs/SLUBStoragePlugin.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java b/java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java
index bb3fbbb..ab39731 100644
--- a/java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java
+++ b/java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java
@@ -176,7 +176,7 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
*/
private boolean checkFixityByPlugin(Fixity fixity, String storedEntityIdentifier, boolean isRelativePath, boolean result) throws Exception {
log.info("SLUBStoragePlugin.checkFixityByPlugin() another fixity");
- String pluginname;
+ String pluginname = "";
try {
pluginname = fixity.getPluginName();
log.info("SLUBStoragePlugin.checkFixityByPlugin() pluginname=" + pluginname);
@@ -185,8 +185,10 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
log.warn("SLUBStoragePlugin.checkFixityByPlugin() hard error getting plugin name, " + e.getMessage());
pluginname = "";
}
- if (pluginname.length() == 0) {
- log.error("SLUBStoragePlugin failed to get pluginname, because it is empty. Possibly, there is no valid fixity typeused or a CustomFixityPlugin missed");
+ finally {
+ if (pluginname == null || pluginname.length() == 0) {
+ log.error("SLUBStoragePlugin failed to get pluginname, because it is empty. Possibly, there is no valid fixity typeused or a CustomFixityPlugin missed");
+ }
}
String oldValue = "";
--
GitLab