From 97a6746c4f34706231a365272f003970fb3255b3 Mon Sep 17 00:00:00 2001
From: Andreas Romeyke <andreas.romeyke@slub-dresden.de>
Date: Mon, 19 May 2025 20:12:24 +0200
Subject: [PATCH] - added checks, fixes
https://git.slub-dresden.de/digital-preservation/tools-for-technical-analysts/-/issues/20
---
lib/SLUB/LZA/TA/Command/info.pm | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/lib/SLUB/LZA/TA/Command/info.pm b/lib/SLUB/LZA/TA/Command/info.pm
index f2841cb..ca3a786 100644
--- a/lib/SLUB/LZA/TA/Command/info.pm
+++ b/lib/SLUB/LZA/TA/Command/info.pm
@@ -33,9 +33,18 @@ sub validate_args {
return 1;
}
+sub _warn_if_no_config {
+ foreach my $key (@_) {
+ warn "Missed configuration for $key, missed initalization via command 'init' or missed command line options!" unless defined $key;
+ }
+ return;
+}
+
sub execute {
my ($self, $opt, $args) = @_;
+ warn "This module needs further work, only '--target-version' and '--version' supported yet" unless defined $opt->{target_version} or defined $opt->{version};
if ($opt->{target_version}) {
+ _warn_if_no_config(qw(elasticsearch_protocol elasticsearch_host elasticsearch_port));
say SLUB::LZA::TA::Archivematica::Elasticsearch::version_elasticsearch(
$SLUB::LZA::TA::config{elasticsearch_protocol},
$SLUB::LZA::TA::config{elasticsearch_host},
@@ -43,8 +52,10 @@ sub execute {
);
}
if ($opt->{version}) {
- say $SLUB::LZA::TA::VERSION;
+ warn "Missed version for Module SLUB::LZA::TA, called from development directory without dzil-based release?" unless defined $SLUB::LZA::TA::VERSION;
+ say $SLUB::LZA::TA::VERSION if defined $SLUB::LZA::TA::VERSION;
}
+
return 1;
}
--
GitLab