style: more linting

handlers/main.yml

@@ -14,8 +14,9 @@
         name: netfilter-persistent
         state: present
       listen: "save iptables rules"
+    # we exclude this task from being linted for "no-changed-when", because handlers only ever run if there's a change triggered by a task
     - name: save iptables rules
-      ansible.builtin.command: 'netfilter-persistent save'
+      ansible.builtin.command: 'netfilter-persistent save'      # noqa no-changed-when
       listen: "save iptables rules"
   when: ansible_os_family == "Debian"
 
@@ -29,8 +30,9 @@
         group: "root"
         mode: "0600"
       listen: "save iptables rules"
+    # we exclude this task from being linted for "no-changed-when", because handlers only ever run if there's a change triggered by a task
     - name: save rules
-      ansible.builtin.command: /usr/sbin/iptables-save        # noqa 303
+      ansible.builtin.command: /usr/sbin/iptables-save        # noqa no-changed-when
       listen: "save iptables rules"
   when: ansible_os_family == "RedHat"
 

molecule/virtualbox_debian11/molecule.yml

@@ -7,7 +7,7 @@ driver:
 lint: |
   set -e
   yamllint .
-  ansible-lint -x no-loop-var-prefix,command-instead-of-module
+  ansible-lint -x no-loop-var-prefix,command-instead-of-module,package-latest
 platforms:
   # Check out the documentation at
   # https://github.com/ansible-community/molecule-vagrant#documentation

tasks/configure_vim.yml

 ---
 # see http://vimdoc.sourceforge.net/htmldoc/starting.html#system-vimrc
 - name: install systemwide vimrc config
-  template:
+  ansible.builtin.template:
     src: "etc/vim/vimrc.local.j2"
     dest: "/etc/vimrc.local"
     owner: "root"