- added null-checks in parameter getters

- fixed throughput(), return result
- added contractAssert...()
- increased debugging output
- fixed wrong retrieveEntity() call, uses relative paths
- added relativePath()
-

PLUGIN-INF/metadata_SLUBStoragePlugin.xml

@@ -70,7 +70,7 @@
 		</fr:x_form>
 	</pl:initParameters>
 	<pl:description>SLUB Storage Plugin</pl:description>
-	<pl:version>2.822</pl:version>
+	<pl:version>2.836</pl:version>
 	<pl:materialType>DIGITAL</pl:materialType>
 	<pl:module>Repository</pl:module>
 	<pl:generalType>TASK</pl:generalType>

java/org/slub/rosetta/dps/repository/plugin/storage/nfs/TestSLUBStoragePlugin.java

@@ -22,6 +22,7 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 
+import static java.nio.file.Path.of;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
@@ -38,7 +39,7 @@ public class TestSLUBStoragePlugin {
   @Before
   public void setUp() throws IOException {
     testroot = Files.createTempDirectory("testslubstorage");
-    Files.createFile(Path.of(testroot.toAbsolutePath().toString() + "/foo"));
+    Files.createFile(of(testroot.toAbsolutePath().toString() + "/foo"));
     mock = new SLUBStoragePlugin();
     HashMap<String, String> map = new HashMap<String,String> ();
     map.put("DIR_ROOT", testroot.toAbsolutePath().toString());
@@ -66,10 +67,15 @@ public class TestSLUBStoragePlugin {
       assertTrue("checkFixity", result);
     }
     catch (Exception e) {
-      assertEquals("checkFixity", "foo", e);
+      assertEquals("checkFixity", "foo", e.getMessage());
     }
   }
 
+  @Test
+  public void relativePath() {
+    String absolute = testroot.toAbsolutePath().toString()+"/2022";
+    assertEquals("relativePath", "/2022", mock.relativePath(absolute));
+  }
   @Test
   public void getFullFilePath() {
     assertEquals( "getFullFilePath", testroot.toAbsolutePath().toString()+"/2022", mock.getFullFilePath("/2022"));
@@ -80,7 +86,18 @@ public class TestSLUBStoragePlugin {
       InputStream is = mock.retrieveEntity("/foo");
       assertTrue("retrieveEntity", true);
     } catch (Exception e) {
-      assertEquals("retrieveEntity", "", e);
+      assertEquals("retrieveEntity", "", e.getMessage());
+    }
+  }
+  @Test
+  public void retrieveEntity_dirroot() {
+    try {
+      InputStream is = mock.retrieveEntity(testroot.toAbsolutePath().toString() + "/foo");
+      assertTrue("retrieveEntity", true);
+    } catch (IllegalArgumentException e) {
+      assertEquals("retrieveEntity", "", e.getMessage());
+    } catch (IOException e) {
+      assertTrue("retrieveEntity", e.getMessage().contains("should be relative, but starts with ROOT"));
     }
   }
   @Test