- added file handle closing (base https://github.com/ExLibrisGroup/Rosetta.CustomNFSStoragePlugin)

java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java

@@ -87,7 +87,7 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
         boolean result = true;
         if (fixities != null)
         {
-            InputStream is;
+            InputStream is = null;
             try {
                 is = retrieveEntity(storedEntityIdentifier, isRelativePath);
                 Checksummer checksummer = new Checksummer(is, true, true, true,true);
@@ -132,6 +132,13 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
             finally
             {
                 // log.info("SLUBStoragePlugin.checkFixity() finally called");
+                if (is != null) {
+                    try {
+                        is.close();
+                    } catch (Exception e) {
+                        log.warn("SLUBStoragePlugin.checkFixity(), failed closing file, " + e.getMessage());
+                    }
+                }
             }
         }
         return result;
@@ -242,7 +249,7 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
     {
         log.info("SLUBStoragePlugin.retrieveEntitybyRange() with '" + storedEntityIdentifier + "' start=" + start + " end=" + end);
         byte[] bytes = new byte[(int)(end - start + 1L)];
-        RandomAccessFile file;
+        RandomAccessFile file = null;
         try
         {
             file = new RandomAccessFile(this.parameters.get("DIR_ROOT") + storedEntityIdentifier, "r");
@@ -264,6 +271,13 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
         finally
         {
             // log.info("SLUBStoragePlugin.retrieveEntityByRange() finally called");
+            if (file != null) {
+                try {
+                    file.close();
+                } catch (Exception e) {
+                    log.warn("SLUBStoragePlugin.retrieveEntitybyRange(), failed closing file, " + e.getMessage());
+                }
+            }
         }
         return bytes;
     }

[Andreas Romeyke]

IMHO sind deklarierte Variablen immer "null" bzw. 0, siehe https://docs.oracle.com/javase/specs/jls/se7/html/jls-4.html#jls-4.12.5

[Jens Steidl]

Sonst Compiler Error (JDK17) bei Prüfung auf null

java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java:137: error: variable is might not have been initialized
                if (is != null) {
                    ^
1 error