- refactoring, splitted BEGIN-block

lib/SLUB/LZA/TA.pm

@@ -24,9 +24,13 @@ BEGIN {
     my $rx_psep = qr{[/\\]};
     my $rx_abs  = qr{[A-Z]:};
     my $rx_sub  = qr{([[:print:]]+)};
-    $ENV{'HOME'} =~ m{^(($rx_abs)?($rx_psep$rx_sub)+)$}m;
-    # untaint $homestr
-    my $homestr = $1;
+    if ($ENV{'HOME'} =~ m{^(($rx_abs)?($rx_psep$rx_sub)+)$}m) {
+        load_config_if_possible($1);
+        load_cache_if_possible($1);
+    }
+}
+
+sub load_config_if_possible ($homestr) {
     my $home = path($homestr);
     if ($home->is_dir() && !$home->is_rootdir) {
         my $config_path = $home->child('.config')->child('ta-tool.rc');
@@ -39,12 +43,22 @@ BEGIN {
             %config = %{$config_ref};
             $config{elasticsearch_protocol} = $config{http_only} ? 'http' : 'https';
         }
+
+    }
+    return 1;
+}
+
+sub load_cache_if_possible ($homestr) {
+    my $home = path($homestr);
+    if ($home->is_dir() && !$home->is_rootdir) {
         $cache_path = $home->child('.cache')->child('ta-tool.cache');
-        if ($cache_path->is_file and -s $cache_path < 8192 * 1024) { # if size > 8MB, write new at end, see END{}-block
+        if ($cache_path->is_file and -s $cache_path < 8192 * 1024) {
+            # if size > 8MB, write new at end, see END{}-block
             my $cache_ref = YAML::LoadFile($cache_path);
             %cache = %{$cache_ref};
         }
     }
+    return 1;
 }
 
 sub common_global_validate ($self, $opt, $args) {