- added test messages

java/org/slub/rosetta/dps/repository/plugin/Validation/TestSLUBValidateDTD.java

@@ -50,8 +50,8 @@ public class TestSLUBValidateDTD {
         } catch ( Exception e) {
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("dtd validation should not raise an exception", has_exception );
+        assertFalse( "dtd validation should return false for failed validation", res);
     }
     @org.junit.Test
     public void dtd_invalid2() {
@@ -72,8 +72,8 @@ public class TestSLUBValidateDTD {
         } catch ( Exception e) {
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse( "dtd validation should not raise an exception", has_exception );
+        assertFalse( "dtd validation should return false for failed validation", res);
     }
 
 
@@ -100,8 +100,8 @@ public class TestSLUBValidateDTD {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertTrue( res);
+        assertFalse("dtd validation should not raise an exception", has_exception );
+        assertTrue("dtd validation should return true for sucessful validation",  res);
     }
 
     @org.junit.Test
@@ -127,8 +127,8 @@ public class TestSLUBValidateDTD {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertTrue( res);
+        assertFalse("dtd validation should not raise an exception", has_exception );
+        assertTrue("dtd validation should return true for sucessful validation",  res);
     }
 
 
@@ -151,8 +151,8 @@ public class TestSLUBValidateDTD {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("dtd validation should not raise an exception", has_exception );
+        assertFalse("dtd validation should return false for failed validation",  res);
     }
 
     @org.junit.Test
@@ -176,7 +176,7 @@ public class TestSLUBValidateDTD {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("dtd validation should not raise an exception", has_exception );
+        assertFalse("dtd validation should return false for failed validation", res);
     }
 }

java/org/slub/rosetta/dps/repository/plugin/Validation/TestSLUBValidateRelaxNG.java

@@ -59,8 +59,8 @@ public class TestSLUBValidateRelaxNG {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertTrue( res);
+        assertFalse("relaxNG validation should not raise an exception", has_exception );
+        assertTrue("relaxNG validation should return true for sucessful validation",  res);
     }
     @org.junit.Test
     public void relaxNG_invalid() {
@@ -76,7 +76,7 @@ public class TestSLUBValidateRelaxNG {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("relaxNG validation should not raise an exception", has_exception );
+        assertFalse( "relaxNG validation should return false for failed validation", res);
     }
 }

java/org/slub/rosetta/dps/repository/plugin/Validation/TestSLUBValidateSchema.java

@@ -64,8 +64,8 @@ public class TestSLUBValidateSchema {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertTrue( res);
+        assertFalse("schema validation should not raise an exception", has_exception );
+        assertTrue("schema validation should return true for sucessful validation",  res);
     }
 
     @org.junit.Test
@@ -83,8 +83,8 @@ public class TestSLUBValidateSchema {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("schema validation should not raise an exception", has_exception );
+        assertFalse("schema validation should return false for failed validation",  res);
     }
 
     @org.junit.Test
@@ -93,7 +93,7 @@ public class TestSLUBValidateSchema {
         Set<ValidationSchema> old = mock.getNamespaceSchemaMap();
         for (ValidationSchema val : old) { // filter Atoim out to trigger error
             System.out.println("###### " + val.nameSpace);
-            if (!val.nameSpace.equals("http://www.w3.org/2005/Atom")) {
+            if (!"http://www.w3.org/2005/Atom".equals(val.nameSpace)) {
                 nssm.add(val);
             }
         }
@@ -110,7 +110,7 @@ public class TestSLUBValidateSchema {
             e.printStackTrace();
             has_exception = true;
         }
-        assertFalse( has_exception );
-        assertFalse( res);
+        assertFalse("schema validation should not raise an exception", has_exception );
+        assertFalse("schema validation should return false for failed validation",  res);
     }
 }