- fixed NPE (Cannot invoke "String.length()" because "<local5>" is null) in...

- fixed NPE (Cannot invoke "String.length()" because "<local5>" is null) in String comparison to tackle underlying issue

java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java

@@ -176,7 +176,7 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
      */
     private boolean checkFixityByPlugin(Fixity fixity, String storedEntityIdentifier, boolean isRelativePath, boolean result) throws Exception {
         log.info("SLUBStoragePlugin.checkFixityByPlugin() another fixity");
-        String pluginname;
+        String pluginname = "";
         try {
             pluginname = fixity.getPluginName();
             log.info("SLUBStoragePlugin.checkFixityByPlugin() pluginname=" + pluginname);
@@ -185,9 +185,11 @@ public class SLUBStoragePlugin extends AbstractStorageHandler {
             log.warn("SLUBStoragePlugin.checkFixityByPlugin() hard error getting plugin name, " + e.getMessage());
             pluginname = "";
         }
-        if (pluginname.length() == 0) {
+        finally {
+            if (pluginname == null || pluginname.length() == 0) {
                 log.error("SLUBStoragePlugin failed to get pluginname, because it is empty. Possibly, there is no valid fixity typeused or a CustomFixityPlugin missed");
             }
+        }
 
         String oldValue = "";
         try {

[Andreas Romeyke]

Den Sinn verstehe ich nicht... du behandelst unten Null-Pointer, dann braucht es keine (überflüssige) Initialisierung

[Jens Steidl]

Sonst Compiler Error (JDK17) bei Prüfung auf null

java/org/slub/rosetta/dps/repository/plugin/storage/nfs/SLUBStoragePlugin.java:193: error: variable pluginname might not have been initialized
            if (pluginname == null || pluginname.length() == 0) {
                ^
1 error

[Andreas Romeyke]

typo in 190, "typeused"

[Andreas Romeyke]

189 würde ich trennen in zwei Fehlermessages. Das eine ist ein Nullpointer-, das andere ein leerer String Fehler.

[Jens Steidl]

typo Fix in abff43f3