- refactoring, extracted _overide_config()

lib/SLUB/LZA/TA.pm

@@ -61,9 +61,8 @@ sub load_cache_if_possible ($homestr) {
     return 1;
 }
 
-sub common_global_validate ($self, $opt, $args) {
-    no warnings;
-    foreach my $override (qw(elasticsearch_host elasticsearch_port http_only permanent_volume)) {
+sub _override_config ($override, $opt) {
+    #no warnings;
     if (
         (exists $opt->{$override})
             and ($config{$override} ne $opt->{$override})
@@ -74,8 +73,14 @@ Hint: override local config with:
 HINT
         $config{$override} = $opt->{$override};
     }
+    #use warnings;
+    return 1;
+}
+
+sub common_global_validate ($self, $opt, $args) {
+    foreach my $override (qw(elasticsearch_host elasticsearch_port http_only permanent_volume)) {
+        _override_config($override, $opt);
     }
-    use warnings;
     # option overrides config
     $config{elasticsearch_protocol} = $config{http_only} ? 'http' : 'https';
     foreach my $volume (@{ $SLUB::LZA::TA::config{permanent_volume} }) {